On Thu, 2020-04-30 at 14:32 +0800, Zhang Rui wrote:
> thermal_notify_framework() is an obsolete API, and iwlwifi is the
> only
> user of it.
> Convert iwlwifi driver to use thermal_zone_device_update() instead.
>
> Note that, thermal_zone_device_update() is able to handle the crossed
> threshold by comparing the current temperature with every trip point,
> so
> ths_crossed variant in iwl_mvm_temp_notif() is probably not needed.
> It is still left there in this patch, in case the debug information
> is
> still needed.
>
> Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx>
Hi, Luca,
Any comments about this patch and patch 6/6?
thanks,
rui
> ---
> drivers/net/wireless/intel/iwlwifi/mvm/tt.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> index 418e59b..6344b6b 100644
> --- a/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> +++ b/drivers/net/wireless/intel/iwlwifi/mvm/tt.c
> @@ -203,9 +203,8 @@ void iwl_mvm_temp_notif(struct iwl_mvm *mvm,
> struct iwl_rx_cmd_buffer *rxb)
>
> if (mvm->tz_device.tzone) {
> struct iwl_mvm_thermal_device *tz_dev = &mvm-
> >tz_device;
> -
> - thermal_notify_framework(tz_dev->tzone,
> - tz_dev-
> >fw_trips_index[ths_crossed]);
> + thermal_zone_device_update(tz_dev->tzone,
> + THERMAL_EVENT_UNSPECIFIED);
> }
> #endif /* CONFIG_THERMAL */
> }
