Christian Lamparter <chunkeey@xxxxxxxxx> writes: > On Tuesday, 5 May 2020 09:20:20 CEST Kalle Valo wrote: >> Frank Schäfer <fschaefer.oss@xxxxxxxxxxxxxx> writes: >> > >> > Am 25.04.20 um 11:28 schrieb Christian Lamparter: >> >> This patch follows up on a bug-report by Frank Schäfer that >> >> discovered P2P GO wasn't working with wpa_supplicant. >> >> This patch removes part of the broken P2P GO support but >> >> keeps the vif switchover code in place. >> > >> > Hmm... no way to fix it ? >> > P2P-GO seems to work fine with p2p_no_group_iface=1, so do you really >> > think it's a good idea / required to remove the whole thing ? >> > >> >> Cc: <stable@xxxxxxxxxxxxxxx> >> > >> > Are you sure about that ? >> > People might be using it... >> >> Christian, what should I do? Take the patch or drop it? > > Well, the way I see it: AR9170's silicon die has been cast before > P2P was a thing. And while it was nice back in '10 then to had have > something to test ath9k with, by todays standards the lack of features > like separate TSF sync and the cacheless BA makes it so that it's holding > back the performance and connection quality of all the clients which are > connected to it. > > So, I think we'll just kicking down the can on that and I'm sorry that > I gave the people the wrong impression. There are much better chips now > that came with P2P in mind. > > So: please take the patch. Sounds good to me, thanks. I'll take the patch. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches