Hi Tomas, > >> > The patch fixes CSR_GP_CNTRL_REG_FLAG_INIT_DONE was set instead of > >> > cleared which disabled moving device to D0U state. > >> > >> when was this mistake introduced. Is it a regression compared to what we > >> have in 2.6.26? > > > > I think you are overstretching the regression-fixes-only rule a little bit... > > It will help nobody, if we don't fix actual _bugs_ and push such fixes > > into the next merge window. > > > > Our goal is to have a stable kernel on release. We don't get to that goal, if > > we defer bugfixes to the next merge window. > > Oh, good I have friends after all :) this is not about that and you don't have to convince me to get these patches included. The line of command is John -> Dave -> Linus. I mentioned it in the other email, that I don't see any problem with these patches at all. They look all good, but the question here is if they are suitable for -rc4 or not. If we keep sending bug fixes that are no clear regression after -rc4, then we likely have -rc5, -rc6, -rc7 and more. Instead -rc5 could have been the last. Linus point was clear here. After the merge window it goes to regression fixing with the goal to release the next kernel quickly. Personally I would take all patches, but if I would be in the position to explain them to Linus, I would reject them. Just see this review as Linus asking the trick question why he should take it. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
