John Crispin <john@xxxxxxxxxxx> writes: > This patch adds support for ethernet rxtx mode to the driver. The feature > is enabled via a new module parameter. If enabled to driver will enable > the feature on a per vif basis if all other requirements were met. > > Signed-off-by: Shashidhar Lakkavalli <slakkavalli@xxxxxxxxx> > Signed-off-by: John Crispin <john@xxxxxxxxxxx> [...] > --- a/drivers/net/wireless/ath/ath11k/mac.c > +++ b/drivers/net/wireless/ath/ath11k/mac.c > @@ -33,6 +33,11 @@ > .max_power = 30, \ > } > > +/* frame mode values are mapped as per enum ath11k_hw_txrx_mode */ > +static unsigned int ath11k_ath11k_frame_mode = ATH11K_HW_TXRX_NATIVE_WIFI; > +module_param_named(ath11k_frame_mode, ath11k_ath11k_frame_mode, uint, 0644); > +MODULE_PARM_DESC(ath11k_frame_mode, "Datapath frame mode"); I don't think we should add ath11k_ prefix to module names, right? So I changed that and documented the values: /* frame mode values are mapped as per enum ath11k_hw_txrx_mode */ static unsigned int ath11k_frame_mode = ATH11K_HW_TXRX_NATIVE_WIFI; module_param_named(frame_mode, ath11k_frame_mode, uint, 0644); MODULE_PARM_DESC(frame_mode, "Datapath frame mode (0: raw, 1: native wifi (default), 2: ethernet)"); Also I added a comment to enum ath11k_hw_txrx_mode so that we don't accidentally change the values. This is now in pending branch: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=f0717ed39d06a9f2fd32edbdf88f29939dc25516 Please check my changes. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
