Search Linux Wireless

Re: [PATCH 07/11] iwlwifi: generic init calibrations framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomas,

> >> This patch fixes a critical bug that only the last calibration result
> >> was applied. On reception of one calibration result all the calibration
> >> was freed. The patch fixes this problem by introducing a generic init
> >> calibration framework which allows variable number of init calibrations
> >> and allows addition new HW.
> >
> > a lot of code changes in -rc4 phase. Please give more details since the
> > patch changes a lot and even introduces a new EXPORT.
> 
> The first sentence is important, the whole framework was buggy.

I got that part, but understand that just changing a framework at the
state of -rc4 is never a good idea. Any possible regression that might
come out of it, could delay the release.

In this case it would actually help to have clear Reviewed-by or
Tested-by statements in the patch. Signed-off only states the authors
and doesn't give this change more credit.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux