Search Linux Wireless

Re: [PATCH 10/11] iwlwifi: fix rx_chain computation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Tomas,

> >> This patch fixes and simplifies rx_chain computation.
> >
> > come on, what does it fix? You are submitting patches for -rc4 kernels.
> 
> The fix is here
> 
> +       /* correct rx chain count accoridng hw settings */

while you are at it. Fix the spelling. It is "according" :)

> +       if (priv->hw_params.rx_chains_num < active_rx_cnt)
> +               active_rx_cnt = priv->hw_params.rx_chains_num;
> +
> +       if (priv->hw_params.rx_chains_num < idle_rx_cnt)
> +               idle_rx_cnt = priv->hw_params.rx_chains_num;
> +
> 
> We would configure 1x2 MIMO like 3x3 -- big trouble

And that should be in the commit message. Even explain the trouble that
it causes.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux