> -----Original Message----- > From: Andrzej Pietrasiewicz <andrzej.p@xxxxxxxxxxxxx> > Sent: Thursday, April 30, 2020 4:47 PM > To: Zhang, Rui <rui.zhang@xxxxxxxxx>; linux-pm@xxxxxxxxxxxxxxx > Cc: linux-wireless@xxxxxxxxxxxxxxx; daniel.lezcano@xxxxxxxxxx; > b.zolnierkie@xxxxxxxxxxx; luca@xxxxxxxxx > Subject: Re: [PATCH 2/6] thermal: core: delete thermal_notify_framework() > Importance: High > > Hi Rui, > > Thanks for the series, > > W dniu 30.04.2020 o 08:32, Zhang Rui pisze: > > Delete thermal_notify_framework() as there is no user of it. > > > > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> > > --- > > drivers/thermal/thermal_core.c | 18 ------------------ > > include/linux/thermal.h | 4 ---- > > 2 files changed, 22 deletions(-) > > > > git grep thermal_notify_framework > Documentation/driver-api/thermal/sysfs-api.rst:4.3. > thermal_notify_framework > > Should the documentation be still documenting a non-existent function? > Right, thanks for the reminder. Will clean it up in next version. > BTW, get_tz_trend() is only used in drivers/thermal/step_wise.c, but is still > exported with EXPORT_SYMBOL(). Probably does not need to be exported > anymore. > Right, that worth a separate cleanup patch. Can you please try this patch and confirm the polling timers are queued/cancelled as expected? thanks, rui
