On Fri, 2020-04-24 at 15:41 -0700, Rajkumar Manoharan wrote:
>
> * @has_he: true iff HE data is valid.
> + * @has_he_6ghz: true iff HE 6 GHz data is valid.
> * @he_cap_elem: Fixed portion of the HE capabilities element.
> * @he_mcs_nss_supp: The supported NSS/MCS combinations.
> * @ppe_thres: Holds the PPE Thresholds data.
> + * @ampdu_factor: Maximum A-MPDU length factor used in 6 GHz.
> + * @ampdu_density: Minimum A-MPDU spacing used in 6 GHz.
> + * @he_6gz_cap: HE 6 GHz Band capability.
typo
> */
> struct ieee80211_sta_he_cap {
> bool has_he;
> + bool has_he_6ghz;
> struct ieee80211_he_cap_elem he_cap_elem;
> struct ieee80211_he_mcs_nss_supp he_mcs_nss_supp;
> u8 ppe_thres[IEEE80211_HE_PPE_THRES_MAX_LEN];
> + u8 ampdu_factor;
> + u8 ampdu_density;
> + u16 he_6ghz_cap;
Maybe these should be in some kind of sub-struct so it's clear what the
"has_he_6ghz" applies to?
> };
>
> /**
> @@ -1272,7 +1280,7 @@ struct station_parameters {
> u8 he_capa_len;
> u16 airtime_weight;
> struct sta_txpwr txpwr;
> - const struct ieee80211_he_6ghz_band_cap *he_6ghz_capa;
> + const u8 *he_6ghz_capa;
hm?
johannes
