> Felix Fietkau <nbd@xxxxxxxx> writes: > > > On 2020-04-28 13:07, Kalle Valo wrote: > >> Lorenzo Bianconi <lorenzo@xxxxxxxxxx> writes: > >> > >>> mt7663 firmware v2 is used for embedded devices since it has more completed > >>> features in AP mode. > >>> Add the capability to specify in mt7615 Kconfig which firmware load first > >>> (v3 or v2) and fallback to the other one if the selected firmware fails > >>> to load > >>> > >>> Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> > >>> --- > >>> .../net/wireless/mediatek/mt76/mt7615/Kconfig | 13 +++++ > >>> .../net/wireless/mediatek/mt76/mt7615/mcu.c | 50 ++++++++++++++++--- > >>> .../wireless/mediatek/mt76/mt7615/mt7615.h | 6 ++- > >>> .../net/wireless/mediatek/mt76/mt7615/pci.c | 2 + > >>> .../net/wireless/mediatek/mt76/mt7615/usb.c | 2 + > >>> 5 files changed, 65 insertions(+), 8 deletions(-) > >>> [...] > > > If you want to switch without recompiling, you can always just delete > > the set of firmware files you don't want to use. The driver will fall > > back to the other type. > > My problem here is the new Kconfig option and the way I see is that this > feature doesn't justify the need of a new Kconfig option. A Kconfig > option shouldn't change the driver behaviour, it should be more about > enabling and disabling components and other compilation specific > configuration. > > What about a module parameter? That would be much better and at least I > can't think of a technical reason why it wouldn't work. ack, I will post a v2 adding a kernel parameter and removing the kconfig entry Regards, Lorenzo > > -- > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Attachment:
signature.asc
Description: PGP signature
