On Fri, Apr 24, 2020 at 06:49:15PM +0000, Luis R. Rodriguez wrote:
> From: Luis Chamberlain <mcgrof@xxxxxxxxxx>
>
> Christoph's patch removed two unsused exported symbols, however, one
> symbol is used by the firmware_loader itself. If CONFIG_FW_LOADER=m so
> the firmware_loader is modular but CONFIG_FW_LOADER_USER_HELPER=y we fail
> the build at mostpost.
>
> ERROR: modpost: "fw_fallback_config" [drivers/base/firmware_loader/firmware_class.ko] undefined!
>
> This happens because the variable fw_fallback_config is built into the
> kernel if CONFIG_FW_LOADER_USER_HELPER=y always, so we need to grant
> access to the firmware loader module by exporting it.
>
> Revert only one hunk from his patch.
>
> Fixes: 739604734bd8e4ad71 ("firmware_loader: remove unused exports")
Fixes: 739604734bd8 ("firmware_loader: remove unused exports")
No need to be over-eager with the number of digits...
I'll fix this up when I apply it, thanks.
greg k-h
