<yhchuang@xxxxxxxxxxx> writes: > From: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > > The logical efuse map is decoded from physical map by parsing the > header format of the physical map. And each different type of chips > has different logical efuse layout. So add the logical map's layout > for parsing the efuse contents. > > Signed-off-by: Ping-Ke Shih <pkshih@xxxxxxxxxxx> > Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> [...] > +static void rtw8723de_efuse_parsing(struct rtw_efuse *efuse, > + struct rtw8723d_efuse *map) > +{ > + ether_addr_copy(efuse->addr, map->e.mac_addr); > +} Feels like an unnecessary extra function to me. But not a big deal, no need to resend because of this. And thanks for splitting the patches, makes my life a lot more pleasant :) -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches