Hello Yen-Hsuan
On 17.04.20 11:03, Tony Chuang wrote:
Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes:
<yhchuang@xxxxxxxxxxx> writes:
From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx>
Although RTL8723DE devices are 802.11n devices, while rtw88
aimed to support for 802.11ac devices, the 8723DE devices's
architecture is relatively close to the 802.11ac devices.
So, add support for them on rtw88, with some minor modifications.
There's no way I'm going to review 40 patches in one go :) So I'll just
to look at around 10 first patches and drop the rest.
If you want your patches reviewed smoothly submit only around 7-12
patches per patchset. If the patches are bigger don't send more than 7
patches. But if they smaller, or trivial patches, 12 patches is ok. But
anything more than 12 patches and I'm sure you will get reviewers
grumpy.
But you can submit multiple patchsets, just try to throttle it down to
avoid bufferbloat in patchwork, ie. send a new patchset every other day
and document the dependencies in the cover letter ("this patchset
depends on patchset B").
I added this also to the wiki:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpa
tches#maximum_of_7-12_patches_per_patchset
Actually I can send the 8723DE within 5 patches, but I thought that split
them will be easier to review :) If too many patches is a problem, then I
can squash them back together, because most of them are hardware
settings. I can resend a v2.
Squashing them together to stay below the patch limit would not really
help reviewers. Its the same amount of code, just in bigger patches.
Most reviewers are way more happy with smaller patches doing one thing
only (atomic). I would assume that Kalle would prefer to keep the
patches split up as you already did. Just arrange them in a few sets
coming in after another. Its really about throttling the amount of code
coming in that needs review to be manageable for reviewers.
regards
Stefan Schmidt
