Wen Gong <wgong@xxxxxxxxxxxxxx> writes: > This patch is to set register to allow the mbox enter sleep status > if it does not have tx traffic and wakeup it if tx traffic arrive. > After mbox enter sleep status, the soc will enter sleep status by > firmware, this will save power. The power consume drops from about > 90mW to about 10mW with this patch. > > This patch only effect sdio chip. > > Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029. > > Signed-off-by: Wen Gong <wgong@xxxxxxxxxxxxxx> [...] > +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool enable_sleep) > +{ > + if (ar->hif.ops->set_mbox_sleep) > + return ar->hif.ops->set_mbox_sleep(ar, enable_sleep); > + return 0; > +} I don't think we need to add another hif op for this. I sent v2 which uses existing op. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches