On Fri, 2020-04-03 at 13:10 -0400, Mark Asselstine wrote: > On Fri, Apr 3, 2020 at 10:38 AM Mark Asselstine <asselsm@xxxxxxxxx> wrote: > > On Fri, Apr 3, 2020 at 4:32 AM Luca Coelho <luca@xxxxxxxxx> wrote: > > > From: Johannes Berg <johannes.berg@xxxxxxxxx> > > > > > > Due to some hardware issues, queue 32 isn't usable on devices that have > > > 32 queues (7000, 8000, 9000 families), > > Is this statement really correct? No, it should've said "queue 31" since they're numbered 0-based ... > All these devices have 31 queues > according to (.num_of_queues = 31). Well, they were supposed to have 32, but there's some issue with the last one. I don't really even remember what's up with it, but we just never use it. > Without a HW specification I can't > be 100% sure but you should have this information within Intel. From > the details of my patch and my investigation, this should be nack'd > along with an explanation as to why my fix is not valid. I don't see any real difference to your fix? Your fix marks them as used before, whereas mine just avoids looking at them. johannes
