Hi Dan,
-----Original Message-----
From: linux-wireless-owner@xxxxxxxxxxxxxxx
<linux-wireless-owner@xxxxxxxxxxxxxxx> On Behalf Of Dan Carpenter
Sent: Tuesday, April 7, 2020 7:11 PM
To: mpubbise@xxxxxxxxxxxxxx
Cc: ath11k@xxxxxxxxxxxxxxxxxxx; linux-wireless@xxxxxxxxxxxxxxx
Subject: [EXT] [bug report] ath11k: handle RX fragments
Hello Manikanta Pubbisetty,
The patch 243874c64c81: "ath11k: handle RX fragments" from Mar 16,
2020, leads to the following static checker warning:
drivers/net/wireless/ath/ath11k/dp_rx.c:3365 ath11k_dp_rx_frag_h_mpdu()
warn: missing error code here? 'ath11k_dp_rx_h_defrag()' failed. 'ret'
= '0'
drivers/net/wireless/ath/ath11k/dp_rx.c
3343
HAL_WBM_REL_BM_ACT_PUT_IN_IDLE);
3344 }
3345
3346 if (!rx_tid->last_frag_no ||
3347 rx_tid->rx_frag_bitmap !=
GENMASK(rx_tid->last_frag_no, 0)) {
3348 mod_timer(&rx_tid->frag_timer, jiffies +
3349
ATH11K_DP_RX_FRAGMENT_TIMEOUT_MS);
3350 goto out_unlock;
^^^^^^^^^^^^^^^
All these gotos should probably set error codes instead of returning
success.
Thanks for pointing out. But, this function was written in this way on
purpose.
The error retval to caller and error goto's in this function perform
different cleanups and moving them to caller will only make the caller
function complex which is better to avoid.
Thanks,
Sriram.R
