On 2020/4/6 21:02, Kalle Valo wrote: > YueHaibing <yuehaibing@xxxxxxxxxx> writes: > >> drivers/net/wireless/ath/ath11k/thermal.h:45:1: >> warning: no return statement in function returning non-void [-Wreturn-type] >> drivers/net/wireless/ath/ath11k/core.c:416:28: error: >> passing argument 1 of ‘ath11k_thermal_unregister’ from incompatible pointer type [-Werror=incompatible-pointer-types] >> >> Add missing return 0 in ath11k_thermal_set_throttling, >> and fix ath11k_thermal_unregister param type. > > These are warnings, no? "build error" and "compiler warning" are > different things, the former breaks the whole build which is super > critical, but I'll queue this to v5.7 nevertheless. And I'll change the > title to: > > ath11k: fix compiler warning without CONFIG_THERMAL Ok , thanks! >