On Sun, 2020-04-05 at 11:44 +0300, Kalle Valo wrote: > Chris Rorvick <chris@xxxxxxxxxxx> writes: > > > Commit 71bc0334a637 ("iwlwifi: check allocated pointer when allocating > > conf_tlvs") attempted to fix a typoe introduced by commit 17b809c9b22e > > ("iwlwifi: dbg: move debug data to a struct") but does not implement the > > check correctly. > > > > Tweeted-by: @grsecurity > > Signed-off-by: Chris Rorvick <chris@xxxxxxxxxxx> > > I'll add: > > Fixes: 71bc0334a637 ("iwlwifi: check allocated pointer when allocating conf_tlvs") > > > --- > > In this wasn't picked up? > > Luca, can I take this directly? Yes, please take it directly. This can happen in OOM situations and, when it does, we will potentially try to dereference a NULL pointer. Thanks! -- Cheers, Luca.