On 4/1/20 12:10 AM, Johannes Berg wrote: > On Tue, 2020-03-31 at 23:21 -0700, Thomas Pedersen wrote: >> >> TODO: several of these commands will eventually just >> ignore the _OFFSET component, like _JOIN_MESH, >> _CMD_RADAR_DETECT, etc. Should return an error to give >> user a hint things won't work as expected? > > Wouldn't most of them already require that a channel with the given > frequency exists, and thus fail anyway? Well I was thinking of the case where you have: ch 2: 903MHz ch 3: 903.5Mhz userspace tries to eg. join a mesh on channel 3 by sending 903MHz + 500KHz, the (old) kernel interprets this as channel 2 and happily joins on the wrong channel. However this only applies on a new band which doesn't even exist yet, and if we return an error for commands which have not yet been tested with frequency offset nothing unexpected will happen. -- thomas
