ssreeela@xxxxxxxxxxxxxx writes: > On 2020-03-26 15:29, Kalle Valo wrote: >> Sowmiya Sree Elavalagan <ssreeela@xxxxxxxxxxxxxx> wrote: >> >>> From: Lei Wang <leiwa@xxxxxxxxxxxxxx> >>> >>> Set right channel frequencies in VHT160 mode according to the VHT160 >>> interoperability workaround added as part of IEEE Std 802.11™-2016 in >>> "Table 9-252—VHT Operation Information subfields", band_center_freq2 >>> corresponds to CCFS1 in Table 9-253. Previous implementation >>> (band_center_freq2 = 0 for VHT160) is only deprecated. >>> >>> Enable VHT80+80 mode and set the proper peer RX nss value for >>> VHT160 and >>> VHT80+80 mode. >>> >>> Based on patches by Sebastian Gottschall: >>> >>> https://lkml.kernel.org/r/20180704095444.662-1-s.gottschall@xxxxxxxxxx >>> >>> https://lkml.kernel.org/r/20180704120519.6479-1-s.gottschall@xxxxxxxxxx >>> >>> Tested: qca9984 with firmware ver 10.4-3.10-00047 >>> >>> Co-developed-by: Sebastian Gottschall <s.gottschall@xxxxxxxxxx> >>> Signed-off-by: Sebastian Gottschall <s.gottschall@xxxxxxxxxx> >>> Co-developed-by: Rick Wu <rwu@xxxxxxxxxxxxxx> >>> Signed-off-by: Rick Wu <rwu@xxxxxxxxxxxxxx> >>> Signed-off-by: Lei Wang <leiwa@xxxxxxxxxxxxxx> >>> Signed-off-by: Sowmiya Sree Elavalagan <ssreeela@xxxxxxxxxxxxxx> >> >> Fails to build on GCC 8.1. Did you test this? >> >> In file included from ./include/asm-generic/bug.h:5, >> from ./arch/x86/include/asm/bug.h:83, >> from ./include/linux/bug.h:5, >> from ./include/net/mac80211.h:16, >> from drivers/net/wireless/ath/ath10k/mac.h:10, >> from drivers/net/wireless/ath/ath10k/mac.c:8: >> In function 'ath10k_peer_assoc_h_vht', >> inlined from 'ath10k_peer_assoc_prepare' at >> drivers/net/wireless/ath/ath10k/mac.c:2790:2: >> ./include/linux/compiler.h:350:38: error: call to >> '__compiletime_assert_2631' declared with attribute error: [...] > I checked the build. Build was successful with GCC version 4.8. > Will fix the error and update the patch. Great, thanks. Here's how I installed GCC 8.1 from crosstool: listings: https://www.kernel.org/pub/tools/crosstool/ wget https://www.kernel.org/pub/tools/crosstool/files/bin/x86_64/8.1.0/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz pushd /opt/cross/ tar -xf ~/tmp/crosstool/x86_64-gcc-8.1.0-nolibc-x86_64-linux.tar.xz In top level create GNUMakefile: CROSS_COMPILE=/opt/cross/gcc-8.1.0-nolibc/x86_64-linux/bin/x86_64-linux- include Makefile -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
