Chi-Hsien Lin <chi-hsien.lin@xxxxxxxxxxx> wrote: > From: Raveendran Somu <raveendran.somu@xxxxxxxxxxx> > > When the control transfer gets timed out, the error status > was returned without killing that urb, this leads to using > the same urb. This issue causes the kernel crash as the same > urb is sumbitted multiple times. The fix is to kill the > urb for timeout transfer before returning error > > Signed-off-by: Raveendran Somu <raveendran.somu@xxxxxxxxxxx> > Signed-off-by: Chi-hsien Lin <chi-hsien.lin@xxxxxxxxxxx> Fails to build: drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c: In function 'brcmf_usb_rx_ctlpkt': drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c:390:3: error: label 'fail' used but not defined goto fail; ^~~~ make[6]: *** [drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.o] Error 1 make[6]: *** Waiting for unfinished jobs.... make[5]: *** [drivers/net/wireless/broadcom/brcm80211/brcmfmac] Error 2 make[4]: *** [drivers/net/wireless/broadcom/brcm80211] Error 2 make[3]: *** [drivers/net/wireless/broadcom] Error 2 make[2]: *** [drivers/net/wireless] Error 2 make[1]: *** [drivers/net] Error 2 make: *** [drivers] Error 2 6 patches set to Changes Requested. 11436667 [V2,1/6] brcmfmac: Fix driver crash on USB control transfer timeout 11436669 [V2,2/6] brcmfmac: Fix double freeing in the fmac usb data path 11436671 [V2,3/6] brcmfmac: fix the incorrect return value in brcmf_inform_single_bss(). 11436673 [V2,4/6] brcmfmac: increase max hanger slots from 1K to 3K in fws layer 11436675 [V2,5/6] brcmfmac: add USB autosuspend feature support 11436677 [V2,6/6] brcmfmac: To support printing USB console messages -- https://patchwork.kernel.org/patch/11436667/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches