Wright Feng <wright.feng@xxxxxxxxxxx> writes: > Arend Van Spriel 於 3/19/2020 4:28 PM 寫道: >> On 3/19/2020 8:53 AM, Wright Feng wrote: >>> When eap_restrict is enabled, firmware will toss non-802.1x frames from >>> tx/rx data path if station not yet authorized. >>> Internal firmware eap_restrict is disabled by default. This patch makes >>> it possible to enable firmware eap_restrict by specifying >>> eap_restrict=1 as module parameter. >> >> What is the reason for not having this toss behavior as default? >> Don't see much reason for having the module parameter. > > The eap_restrict feature in most of firmwares are disabled as default, > and refer to our experience, using eap_restrict increases roam time > for associations in some cases. What are these these cases exactly? > So what we do in this patch is not changing the default firmware > behavior but still give users a way to enable eap_resrtict feature. You should have mentioned this (ie. answer the "Why?" part) in the commit log in the first place. But I don't like adding module parameters unless with really good reasons. And in this case there's no proper documentation when and how a user should use the module parameter so this is nowhere near a proper justifiction. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
