Jonathan Corbet <corbet@xxxxxxx> writes: > On Wed, 18 Mar 2020 21:43:10 +0100 > Thomas Gleixner <tglx@xxxxxxxxxxxxx> wrote: >> Add initial documentation. > > ...time to add a a couple of nits...:) ...time Is that valid RST? >> +++ b/Documentation/locking/locktypes.rst >> @@ -0,0 +1,298 @@ >> +.. _kernel_hacking_locktypes: >> + > > So ... I vaguely remember that some Thomas guy added a document saying we > should be putting SPDX tags on our files? :) Never met him or heard about that. >> + >> +The preferred solution is to use :c:func:`spin_lock_irq()` or >> +:c:func:`spin_lock_irqsave()` and their unlock counterparts. > > We don't need (and shouldn't use) :c:func: anymore; just saying > spin_lock_irq() will cause the Right Things to happen. Good to know. Will fix. Thanks, tglx