Kalle Valo <kvalo@xxxxxxxxxxxxxx> writes:
> Larry Finger <Larry.Finger@xxxxxxxxxxxx> wrote:
>
>> For some unexplained reason, commit d1d1a96bdb44 ("rtlwifi: rtl8188ee:
>> Remove local configuration variable") broke at least one system. As
>> the only net effect of the change was to remove 2 bytes from the start
>> of struct phy_status_rpt, this patch adds 2 bytes of padding at the
>> beginning of the struct.
>>
>> Fixes: d1d1a96bdb44 ("rtlwifi: rtl8188ee: Remove local configuration variable")
>> Cc: Stable <stable@xxxxxxxxxxxxxxx> # V5.4+
>> Reported-by: Ashish <ashishkumar.yadav@xxxxxxxxxxxxxxxxxxxxxxxx>
>> Tested-by: Ashish <ashishkumar.yadav@xxxxxxxxxxxxxxxxxxxxxxxx>
>> Signed-off-by: Larry Finger <Larry.Finger@xxxxxxxxxxxx>
>
> Patch applied to wireless-drivers.git, thanks.
>
> c80b18cbb04b rtlwifi: rtl8188ee: Fix regression due to commit d1d1a96bdb44
While writing the pull request for Dave I noticed that the commit log
does not describe the symptoms in any way. I found the report (connect
issues) but in the future please describe the bug from user's point of
view in the commit log, not just the solution.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
