Hi Johannes, >>> This allows communication with external entities. >>> >>> It also required fixing up the netlink policy, since NLA_UNSPEC >>> attributes are no longer accepted. >>> >>> Signed-off-by: Erel Geron <erelx.geron@xxxxxxxxx> >>> [port to backports, inline the ID, use 29 as the ID as requested, >>> drop != NULL checks, reduce ifdefs] >>> Signed-off-by: Johannes Berg <johannes.berg@xxxxxxxxx> >> >> since the module now can auto-load, don’t you want to change radios = 2 to radio = 0? > > Hmm. I didn't really want to change the behaviour there, and the auto- > loading is *highly* unlikely, you need to specifically set up a vhost- > user wmediumd (which I'm in the process of publishing). > > And even then, you still need to have the radios, they just don't > communicate directly with each other but will go into wmediumd over the > virtio when you actually have virtio. > > I'm not principally opposed to changing the default, but I'm not > convinced it'd be related to this patch in any way. can we just make it a Kconfig option that defaults to 2, but gets set to 0 when virtio support is included. Regards Marcel
