On Wed, 2020-03-04 at 13:32 +0100, Markus Theil wrote: > > Yes, its trace-cmd output. Without this patch, the print fmt in the > trace data file looks like this: > print fmt: "%s, netdev:%s(%d), %pM, proto: 0x%x, unencrypted: %s", > REC->wiphy_name, REC->name, REC->ifindex, (REC->dest), > (__u16)__builtin_bswap16((__u16)(( __u16)(__be16)(REC->proto))), > (REC->unencrypted) ? "true" : "false" > > With the patch, the builtin_bswap16 does not get placed there: Sure. But trace-cmd has infrastructure to handle such "function calls" in the output format, so it should be able to handle this pretty easily. So really it's mostly a presentation issue, and having the data in big endian when it's that way over the air etc. IMHO does make sense. johannes
