Hi Johannes, On Mon, Feb 24, 2020 at 1:21 PM Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > > This also hints at a deficiency in the wowlan APIs: [...] > Yeah, well, we didn't dream up arbitrary restrictions when the API was > added :-) Sure, I didn't expect that sort of foresight ;) I was just highlighting that (if rtw88 can't fix it some other way) rtw88 may need to extend the current APIs. > It's maybe a bit harder now to add them, but we can do it in cfg80211, > and reject it if the conditions are not met, and then older userspace > will simply not be able to figure out easily why it was rejected, if it > doesn't understand some new features bits/capability advertisement, I > guess? Seems reasonable. > Ideally, this can just be fixed; Yes, I'd like to see what Realtek folks have to say. > if not, IMHO better to add some > advertisement bits, but if not then we can surely add some kind of > filter callback that's invoked at config time, rather than only at > suspend time when it's way too late to do anything about it. Yeah, I'd have to see what sort of restrictions we're working with -- sufficiently complex rules might not make for good "advertisement" bits. Thanks for your thoughts, Brian
