Hi Johannes,
On 2/24/20 12:26 PM, Johannes Berg wrote:
On Mon, 2020-02-24 at 10:56 -0600, Denis Kenzior wrote:
So to me this patch set seemed like a good idea... We (iwd) don't have
plans to support pre-auth in AP mode in the near future, so this revert
doesn't really affect us. I do wonder what is the actual concern to
warrant a revert?
These are two entirely different things, preauth is simply real data as
far as the local system is concerned. It's not related to controlled
port operation at all, which this nl80211 API is about.
I can understand this argument, but from what I remember, one of the
goals of the control port API was to make this legacy 'special data
packet' processing unnecessary for userspace. In other words userspace
wouldn't need to establish raw sockets. Hence my question, what is the
actual concern here?
FWIW, you may have seen Markus's patch to remove preauth from the RX as
well, this won't work as is, but I'm still a bit on the fence as to
whether I'll force you into the right model or not (i.e. clear the
existing capability bit in mac80211, and introduce a new one that
doesn't report preauth over nl80211). For RX, however, the difference
isn't really that much of a big deal, so maybe just make it optional.
We're actually quite happy with the current model. So I'd like to keep
things as they are.
Regards,
-Denis
