On Sat, 2020-02-22 at 15:25 +0200, Jouni Malinen wrote: > > - if (!err) > + if (err) > + GENL_SET_ERR_MSG(info, "key not allowed"); > + if (!err) { > err = rdev_add_key(rdev, dev, key.idx, [...] Had to read this twice, but I don't see any reason not to put an else there? :) I can fix it up later when I apply it. Thanks, btw, BIGTK was definitely something we were also looking into now. johannes