> On 2/13/2020 10:56 AM, Arend Van Spriel wrote: > > > > > > On 2/13/2020 6:08 AM, yhchuang@xxxxxxxxxxx wrote: > >> From: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx> > >> > >> Set wiphy flag WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL, because > mac80211 > >> actually supports it. With the flag set, driver can accept ROC > >> event from wpa_supplicant or some other user space tools. > > > > This does not seem right. mac80211 does set this flag itself when the > > driver provides remain_on_channel callback. Does that mean you already > > have that callback? This patch is either wrong or unnecessary. > > Re-reading the commit message I guess it is ok to claim > remain-on-channel support when using sw_scan. If this is true it seems > better to extend the condition in ieee80211_alloc_hw_nm() for setting > the flag. > It looks like we can set the flag in ieee80211_alloc_hw_nm(). Such as: if (!use_chan_ctx || (use_chan_ctx && ops->remain_on_channel)). Yan-Hsuan
