Search Linux Wireless

Re: [PATCH 3/6] brcmfmac: fix the incorrect return value in brcmf_inform_single_bss().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 02/13/2020 5:30, Arend Van Spriel wrote:
On 2/13/2020 9:44 AM, Chi-Hsien Lin wrote:
From: Raveendran Somu <raveendran.somu@xxxxxxxxxxx>

The function brcmf_inform_single_bss returns the value as success,
even when the length exceeds the maximum value.
The fix is to send appropriate code on this error.
This issue is observed when SVT reported random fmac crashes
when running their tests and the path was identified from the
crash logs. With this fix the random failure issue in SVT was
resolved.

Although I know what SVT is it not clear in a public commit message. Just refer to "Broadcom test group" or something similar. It would be good to have the crash log in the commit message though. I suspect it occurs upon next_bss_le() call, but having the crash log is better than having me guess. Anyway, here is my...

Reviewed-by: Arend van Spriel <arend.vanspriel@xxxxxxxxxxxx>

Arend,

Thanks a lot for the feedback. I'll update the comment in V2. This is an issue that we solved a while back. I'll do some search and see if I can find the crash log.

Regards,
Chi-hsien Lin


Regards,
Arend
.




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux