On Sunday 17 August 2008 20:16:17 John W. Linville wrote:
> On Sat, Aug 02, 2008 at 02:56:26PM -0300, Henrique de Moraes Holschuh wrote:
> > Switch sysfs parsing to something that actually works properly.
>
> > @@ -402,7 +410,7 @@ static ssize_t rfkill_claim_store(struct device *dev,
> > if (error)
> > return error;
> >
> > - if (rfkill->user_claim != claim) {
> > + if (!!rfkill->user_claim != !!claim) {
> > if (!claim) {
> > mutex_lock(&rfkill->mutex);
> > rfkill_toggle_radio(rfkill,
>
> This looks a bit funny. Is the '!!' in front of 'rfkill->user_claim'
> really necessary? Especially since...
You can remove the !! in front of rfkill->user_claim, because rfkill->user_claim
is bool anyway. The compiler will implicitely apply !! to it where it is needed.
--
Greetings Michael.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
