On Feb 07, Felix Fietkau wrote: > On 2020-02-06 00:53, Lorenzo Bianconi wrote: > > Introduce mt76_mcu data structure to contain common fields between > > mt76u_mcu and mt76e_mcu. > > Move mt76u_mcu at the beginning of mt76_usb in order to rely on mt76_mcu > > to access mt76u_mcu common fields > Why not move it to struct mt76_dev directly and out of the union? > I think that would be cleaner, and you can also initialize its fields in > mt76_alloc_device(). ack and I can maintain the usb specific fields (e.g mt76_reg_pair or burst) in mt76u_mcu. I will fix it in v2 Regards, Lorenzo > > - Felix >
Attachment:
signature.asc
Description: PGP signature
