On Thu, Feb 6, 2020 at 11:28 AM <yhchuang@xxxxxxxxxxx> wrote:
>
> From: Tzu-En Huang <tehuang@xxxxxxxxxxx>
>
> In associating and configuring beamformee, bfee->role is not
> correctly set before rtw_chip_ops::config_bfee().
> Fix it by setting it correctly.
>
> Fixes: 0bd9557341b7 ("rtw88: Enable 802.11ac beamformee support")
> Signed-off-by: Tzu-En Huang <tehuang@xxxxxxxxxxx>
> Signed-off-by: Yan-Hsuan Chuang <yhchuang@xxxxxxxxxxx>
> ---
>
> v1 -> v2
> * cannot put bfee->role = RTW_BFEE_NONE after out_unlock
> put it enclosed by else
>
> drivers/net/wireless/realtek/rtw88/bf.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtw88/bf.c b/drivers/net/wireless/realtek/rtw88/bf.c
> index fda771d23f71..073c754e9e70 100644
> --- a/drivers/net/wireless/realtek/rtw88/bf.c
> +++ b/drivers/net/wireless/realtek/rtw88/bf.c
> @@ -99,10 +98,11 @@ void rtw_bf_assoc(struct rtw_dev *rtwdev, struct ieee80211_vif *vif,
> }
>
> chip->ops->config_bfee(rtwdev, rtwvif, bfee, true);
> + } else {
> + bfee->role = RTW_BFEE_NONE;
> }
>
Do we really need this `else` section? The bfee->role is only for
`config_bfee`, right? If we don't
need to config_bfee for RTW_BFEE_NONE, then we don't need the `else` part.
Chris
> out_unlock:
> - bfee->role = bfee_role;
> rcu_read_unlock();
> }
>
> --
> 2.17.1
>
