From: Ajay Singh <ajay.kathat@xxxxxxxxxxxxx> The patch series contains changes to address the below code review comments - 1/ Avoid use of infinite loops. 2/ Use separate header file to keep firmware related 'struct'. 3/ Remove unused code. Ajay Singh (4): staging: wilc1000: remove use of infinite loop conditions staging: wilc1000: move firmware API struct's to separate header file staging: wilc1000: added 'wilc_' prefix for 'struct assoc_resp' name staging: wilc1000: remove unused code prior to throughput enhancement in SPI drivers/staging/wilc1000/fw.h | 119 +++++++++++++++++++++++ drivers/staging/wilc1000/hif.c | 90 +---------------- drivers/staging/wilc1000/hif.h | 19 ---- drivers/staging/wilc1000/netdev.c | 7 +- drivers/staging/wilc1000/netdev.h | 1 - drivers/staging/wilc1000/spi.c | 143 +-------------------------- drivers/staging/wilc1000/wlan.c | 79 ++++++--------- drivers/staging/wilc1000/wlan_cfg.c | 144 ++++++++++------------------ drivers/staging/wilc1000/wlan_if.h | 1 + 9 files changed, 209 insertions(+), 394 deletions(-) create mode 100644 drivers/staging/wilc1000/fw.h -- 2.24.0