On Sun, 2019-12-22 at 18:24 +0100, Toke Høiland-Jørgensen wrote:
> Didn't have a chance to
> do anything other than compile-test it yet, but wanted to get it out
> before the holidays (which I almost managed, since technically my
> holiday started two days ago)...
Didn't help you much, I at least was already on vacation by then too :P
> @@ -1948,6 +1978,7 @@ void ieee80211_sta_update_pending_airtime(struct ieee80211_local *local,
> tx_pending, 0);
> }
>
> +
nit, what's that doing here? :)
> +#define IEEE80211_RECIPROCAL_DIVISOR 0x100000000ULL
> +#define IEEE80211_RECIPROCAL_SHIFT 32
Could we live with less precision and use 32-bit arithmetic only? That
might help 32-bit systems?
This is basically a 32.32 (31.32 for signed) fixed point number, right?
So I guess I'm asking if we could live with 16.16 (or 15.16), or
similar.
> @@ -525,6 +532,7 @@ struct ieee80211_sta_rx_stats {
> * @status_stats.ack_signal_filled: last ACK signal validity
> * @status_stats.avg_ack_signal: average ACK signal
> */
> +
another pointless blank line
> + air_info = to_airtime_info(&txqi->txq);
> + ret = (air_info->v_t <= air_sched->v_t);
no need for parentheses :)
I think overall this looks good. I guess you should subject it to some
testing since I can't.
johannes
