On Sun, Dec 29, 2019 at 10:07 PM <tamizhr@xxxxxxxxxxxxxx> wrote: > > Hi Rob, > > Thanks for your review comments. > > >> This adds new dt entries qcom,coexist-support and > >> qcom,coexist-gpio-pin > >> which will be used by ath10k driver to identify coex support > >> of a hardware and notify wifi firmware the gpio pin number. > >> This pin number information is needed for the hardware QCA4019. > >> > >> Signed-off-by: Tamizh Chelvam <tamizhr@xxxxxxxxxxxxxx> > >> --- > >> Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt | 6 > >> ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > >> b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > >> index 0171283..a41e936 100644 > >> --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > >> +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath10k.txt > >> @@ -87,6 +87,10 @@ Optional properties: > >> Definition: Quirk specifying that the firmware expects the 8bit > >> version > >> of the host capability QMI request > >> - qcom,xo-cal-data: xo cal offset to be configured in xo trim > >> register. > >> +- qcom,coexist-support : should contain eithr "0" or "1" to indicate typo > >> coex > >> + support by the hardware. > >> +- qcom,coexist-gpio-pin : gpio pin number information to support > >> coex > >> + which will be used by wifi firmware. > > > > What combinations of these 2 properties are valid? > > > > Is qcom,coexist-gpio-pin required for coexist support? If so then it > > alone should be enough to enable/disable coexist. > > > qcom,coexist-gpio-pin is required for QCA4019 devices. And other ath10k > devices doesn't required that value. > So only added two fields to enable/disable coexist and another for > notifying the gpio pin info. Okay. 'qcom,coexist-support' can be boolean instead. Unless you need it to override a default setting. Rob
