On 12/18/19 10:37 AM, Lorenzo Bianconi wrote:
> [...]
>>
>> @@ -244,19 +248,15 @@ static void mt76x02u_pre_tbtt_enable(struct mt76x02_dev *dev, bool en)
>>
>> static void mt76x02u_beacon_enable(struct mt76x02_dev *dev, bool en)
>> {
>> - int i;
>> -
>> if (WARN_ON_ONCE(!dev->mt76.beacon_int))
>> return;
>>
>> if (en) {
>> mt76x02u_start_pre_tbtt_timer(dev);
>> } else {
>> - /* Timer is already stopped, only clean up
>> - * PS buffered frames if any.
>> + /* Timer is already stopped,
>> + * nothing else to do here.
>> */
>> - for (i = 0; i < N_BCN_SLOTS; i++)
>> - mt76x02_mac_set_beacon(dev, i, NULL);
>> }
> I guess here you can get rid of 'else' branch
>
> Regards,
> Lorenzo
I changed my patch regarding to your suggestions. I'll wait with sending
another iteration on comments to the
4B alignment of beacons.
Markus
>> }
>>
>> --
>> 2.24.0
>>
