Search Linux Wireless

Re: [PATCH 2/4] mac80211: fix issue in loop scenario

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



在 2019-12-13 17:56,Johannes Berg 写道:
On Fri, 2019-12-13 at 15:19 +0800, Yibo Zhao wrote:
In a loop txqs dequeue scenario, if the first txq in the rbtree gets
removed from rbtree immediately in the ieee80211_return_txq(), the
loop will break soon in the ieee80211_next_txq() due to schedule_pos
not leading to the second txq in the rbtree. Thus update schedule_pos
to previous node once the node of schedule_pos is either removed from
rbtree or move to other location in rbtree due to airtime update.

For my understanding - this is a fix to the first patch in the series?

I guess you didn't squash it because that's Toke's patch or something?

I tend to think you still should, and annotate the changes, but I wanted
to understand it first.

Hi Johannes,

Yes, this is a fix to the first patch. Actually, the rest of two patches are also serve the same. So, are you suggesting to merge them to the first patch?

Previouly, I had added Toke's signature in this patch but Toke advised to delete it. I feel a little bit confused about how to handle it. Appreciate any detail guide.

johannes



[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux