> +/**
> + * enum nl80211_bss_color_attributes - BSS Color attributes
> + * @__NL80211_HE_BSS_COLOR_ATTR_INVALID: Invalid
> + *
> + * @NL80211_HE_BSS_COLOR: the current BSS Color.
> + * @NL80211_HE_BSS_COLOR_DISABLED: is BSS coloring disabled.
> + * @NL80211_HE_BSS_COLOR_PARTIAL: the AID equation to be used..
It makes the names somewhat awkwardly long, but I think _ATTR should be
included here like the invalid/last/max, to make clear it's not the
color itself or something like that?
> +static const struct nla_policy
> +he_bss_color_policy[NL80211_HE_BSS_COLOR_ATTR_MAX + 1] = {
I didn't realize this before and really thought about it only because I
saw the one for the nl80211_policy in the context now, but I guess this
should have a strict start type like below:
> [0] = { .strict_start_type = NL80211_ATTR_HE_OBSS_PD },
though in this case we can probably do
[0] = { .strict_start_type = 0 },
to indicate that all these should be treated strictly.
Also, not directly related to any code, can't the BSS color change, and
thus you need a method to update it?
johannes
