On Fri, 2019-12-13 at 16:57 +0100, John Crispin wrote:
> Right now we only track the actual color but not the other bits contained
> within the he_oper field. Fix this by creating a new struct to hold all
> of the info.
>
> Signed-off-by: John Crispin <john@xxxxxxxxxxx>
> ---
> include/net/cfg80211.h | 15 +++++++++++++++
> include/net/mac80211.h | 2 ++
> 2 files changed, 17 insertions(+)
I think you should drop this patch and put the cfg80211 and mac80211
update into the second and third patch of this series, respectively. It
doesn't make much sense to add some unused structs.
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 8140c4837122..e395ef48af83 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -259,6 +259,19 @@ struct ieee80211_he_obss_pd {
It looks like I didn't see that previously for that one,
> + * struct ieee80211_he_bss_color - AP settings for BSS coloring
but I'd kinda prefer this be called cfg80211_... since it's not part of
ieee80211.h with all the over-the-air struct definitions. I'm sure we
have some non-over-the-air things that are called ieee80211_*, but ...
johannes
