On 2019-12-15 09:54, Lorenzo Bianconi wrote: > Rely on FIELD_PREP macro for led register definitions and > remove open coding > > Signed-off-by: Lorenzo Bianconi <lorenzo@xxxxxxxxxx> Please move the FIELD_PREP from the header files to the source file to be consistent with the rest of the code. Same applies to the mt7615 patch. - Felix