Search Linux Wireless

Re: [RFC PATCH v1 4/4] nl80211: Allow deleting stations in ibss mode to reset their state.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2019-12-09 at 11:28 +0100, Nicolas Cavallari wrote:
> 
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index da5262b2298b..82046c990a2a 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -6073,7 +6073,8 @@ static int nl80211_del_station(struct sk_buff *skb, struct genl_info *info)
>  	if (dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP &&
>  	    dev->ieee80211_ptr->iftype != NL80211_IFTYPE_AP_VLAN &&
>  	    dev->ieee80211_ptr->iftype != NL80211_IFTYPE_MESH_POINT &&
> -	    dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO)
> +	    dev->ieee80211_ptr->iftype != NL80211_IFTYPE_P2P_GO &&
> +	    dev->ieee80211_ptr->iftype != NL80211_IFTYPE_ADHOC)
>  		return -EINVAL;

If we go this route (and I'm not sure, shouldn't be _that_ hard to do
some kind of auth/deauth thing?) then you probably should make this
depend on an nl80211 extended feature bit.

That way, not only do you get visibility in userspace whether it's
supported, but also avoid the need to change those non-mac80211 drivers
(by having only mac80211 set the extended feature)

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux