On Mon, Dec 02, 2019 at 03:16:35PM -0800, Brian Norris wrote: > A bit late, but a few readability and maintainability thoughts: I worded most of my suggestions in the form of a patch here: [PATCH] mwifiex: drop most magic numbers from mwifiex_process_tdls_action_frame() https://lore.kernel.org/linux-wireless/20191206194535.150179-1-briannorris@xxxxxxxxxxxx/T/#u https://patchwork.kernel.org/patch/11277011/ Regards, Brian