On Tue, 2019-12-03 at 09:08 +0000, Kalle Valo wrote: > Luciano Coelho <luciano.coelho@xxxxxxxxx> writes: > > > On Tue, 2019-12-03 at 07:39 +0000, Kalle Valo wrote: > > > Anders Kaseorg <andersk@xxxxxxx> writes: > > > > > > > This reverts commit 968dcfb4905245dc64d65312c0d17692fa087b99. > > > > > > > > Both that commit and commit 809805a820c6445f7a701ded24fdc6bbc841d1e4 > > > > attempted to fix the same bug (dead assignments to the local variable > > > > cfg), but they did so in incompatible ways. When they were both merged, > > > > independently of each other, the combination actually caused the bug to > > > > reappear, leading to a firmware crash on boot for some cards. > > > > > > > > https://bugzilla.kernel.org/show_bug.cgi?id=205719 > > > > > > > > Signed-off-by: Anders Kaseorg <andersk@xxxxxxx> > > > > --- > > > > [Nope it was more than just format=flowed damage. This one should be > > > > better for real.] > > > > > > This is nitpicking but as a general comment I would prefer to use simple > > > version numbering v2, v3 and so on. Trying to sort v1.2 in a script is > > > awful. So calling this version v3 is very much preferred, it's not like > > > we are running out of numbers :) > > > > Kalle, this patch makes sense. There was some merge damage because the > > functions were moved around and the local variables' names have > > changed, causing this mess. > > > > Can you please take this patch to v5.4 fixes when you're satisfied? > > Ok, I assigned this to myself and queue for v5.5. Thanks! And yeah, I meant v5.5, obviously. It should reach v5.4 as part of stable. -- Cheers, Luca.
