2019년 11월 27일 (수) 오후 7:48, Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx>님이 작성: > > On 27.11.2019 8:43, Austin Kim wrote: > > > As 'channel' is declared as u16, the following statement is always false. > > channel < 0 > > > > So we can remove unnecessary 'always false' statement. > > It's an expression, not a statement. > According to below link, it is okay to use 'statement' in above case. https://en.wikipedia.org/wiki/Statement_(computer_science) Why don't you show your opition about patch rather than commit message? Thanks, Austin Kim > > Signed-off-by: Austin Kim <austindh.kim@xxxxxxxxx> > > --- > > drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c > > index 3f09d89..7f2c15c 100644 > > --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c > > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c > > @@ -5408,7 +5408,7 @@ int brcms_c_set_channel(struct brcms_c_info *wlc, u16 channel) > > { > > u16 chspec = ch20mhz_chspec(channel); > > > > - if (channel < 0 || channel > MAXCHANNEL) > > + if (channel > MAXCHANNEL) > > return -EINVAL; > > > > if (!brcms_c_valid_chanspec_db(wlc->cmi, chspec)) > > MBR, Sergei >
