On Tuesday 05 August 2008 18:23:16 Larry Finger wrote:
>
> + /* FIXME: The sequence that follows is needed for this driver to
> + * work with mac80211 since "mac80211: fix TX sequence numbers".
> + * As with the temporary code in rt2x00, changes will be needed
> + * to get proper sequence numbers on beacons. In addition, this
> + * patch places the sequence number in the hardware state, which
> + * limits us to a single virtual state.
> + */
> + if (info->flags & IEEE80211_TX_CTL_ASSIGN_SEQ) {
> + if (info->flags & IEEE80211_TX_CTL_FIRST_FRAGMENT)
> + priv->seqno += 0x10;
> + ieee80211hdr->seq_ctrl &= cpu_to_le16(IEEE80211_SCTL_FRAG);
> + ieee80211hdr->seq_ctrl |= cpu_to_le16(priv->seqno);
> + }
???
What is this for? The firmware does the sequence number counting
and will simply override this field without looking at it... Are you sure this
really fixes anything?
That said: the firmware will always report the sequence number of every
tx'ed frame as a part of p54_frame_sent_hdr in the _free_ tx callback...
Regards,
Chr.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
