On Thu, 2019-11-14 at 12:50 +0530, Tamizh chelvam wrote:
>
> > I'm almost thinking that these should be a struct with two u8 values
> > instead of two separate attributes, and then renamed to
> > NL80211_TID_CONFIG_ATTR_RETRY, to carry both and really ensure thaty
> > they're always together as a single configuration.
> >
> This will make mandatory for user to send both values know ?
Yes.
> I have did
> it similar to
> NL80211_ATTR_WIPHY_RETRY_SHORT and NL80211_ATTR_WIPHY_RETRY_LONG. This
> way we can have
> option to configure single parameter know ?
Is it worth it? If you need them to be separate, then you should
actually separate them and let each one be managed per station with
override etc., but that seems a lot of effort?
> > > + [NL80211_TID_CONFIG_ATTR_RETRY] = { .type = NLA_FLAG },
> > > + [NL80211_TID_CONFIG_ATTR_RETRY_SHORT] = { .type = NLA_U8},
> > > + [NL80211_TID_CONFIG_ATTR_RETRY_LONG] = { .type = NLA_U8},
> >
> > The min value of 1 should be reflected in the policy.
> >
> Yeah, It was there in the previous patchset and removed due to
> confusion.
> Do you want to keep MIN value of 1 policy ?
If 0 is invalid, yeah, keep min 1 in the policy.
johannes
