On Thursday 07 August 2008 17:59:26 Larry Finger wrote: > Chr wrote: > > On Thursday 07 August 2008 15:27:51 Johannes Berg wrote: > >>> + priv->tx_stats[le32_to_cpu(entry_data->frame_type - 4)].len--; > >> > >> Sorry for not catching this earlier, but this looks wrong, the -4 surely > >> should be outside the endian conversion? > > > > likely... let's do the job properly for once and for all. > > -- > > > > This patch fixes not only the regression which has sneaked in > > with commit b19fa1f, but also provides some extra code for > > cts rates. > > > > Signed-off-by: Christian Lamparter <chunkeey@xxxxxx> > > Is the extra code for cts rates a bug fix or a feature enhancement? If the > latter, then this patch should be in two parts. The main reason is that > fixes should go to stable as well as wireless-testing. > The old logic always tx'ed cts frames (if enabled) with a short preamble when [rate > 3]. (read: with any 802.11g rate). Of course this isn't that bad, but it's still wrong! Regards, Chr -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
