Search Linux Wireless

Re: [PATCH] mac80211: fix overwriting of qos_ctrl.tid field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-11-19 at 14:34 +0100, Fredrik Olofsson wrote:
> Fixes overwriting of qos_ctrl.tid field for encrypted frames injected on
> monitor interface. qos_ctrl.tid is protected by the encryption, and
> cannot be modified after encryption. For injected frames, the encryption
> key may not be available.
> 
> Before passing the frame to the driver, the qos_ctrl.tid field is
> updated from skb->priority. Prior to dbd50a851c50 skb->priority was
> updated in ieee80211_select_queue_80211(), but this function is no longer
> always called. This patch tries to mimmic the previous behaviour by
> updating skb->priority in ieee80211_monitor_start_xmit().

I'm not sure I understand.

If the QoS field is overwritten (where, btw?) then wouldn't that still
be done even after this change, and if the frame is pre-encrypted it is
corrupted?

johannes




[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux