On 21/11/2019 23:41, Brian Norris wrote:
Hit when, for instance, I'm stupid enough to type an invalid scan
command:
# iw wlan0 scan -h
BUG at file position lib/msg.c:572:void nlmsg_free(struct nl_msg *)
iw: lib/msg.c:572: void nlmsg_free(struct nl_msg *): Assertion `0' failed.
Aborted (core dumped)
Fixes: 2f74c59cf11e ("iw: fix memory leaks inside handle_scan")
Cc: John Crispin <john@xxxxxxxxxxx>
wasn't me, nobody saw do anything
try
367e7dd3 (Amit Khatri 2015-06-26 09:02:36 +0000 451)
nlmsg_free(ssids);
367e7dd3 (Amit Khatri 2015-06-26 09:02:36 +0000 452)
nlmsg_free(freqs);
???
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
---
scan.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/scan.c b/scan.c
index 1418da73a624..bfd39e4b1a1c 100644
--- a/scan.c
+++ b/scan.c
@@ -448,8 +448,6 @@ static int handle_scan(struct nl80211_state *state,
}
/* fall through - this is an error */
case DONE:
- nlmsg_free(ssids);
- nlmsg_free(freqs);
err = 1;
goto nla_put_failure;
case FREQ:
